feat(keychain-vault): add prometheus exporter #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagpreetsinghsasan
force-pushed
the
feature-536
branch
from
e730dab to
aef46d7
Compare
jagpreetsinghsasan
requested review from
jonathan-m-hamilton and
petermetz
as code owners
takeutak
previously approved these changes
Mar 15, 2021
jagpreetsinghsasan
force-pushed
the
feature-536
branch
from
aef46d7 to
9ec5ac8
Compare
petermetz
requested changes
Mar 16, 2021
packages/cactus-plugin-keychain-vault/src/main/typescript/plugin-keychain-vault.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-keychain-vault/src/main/typescript/plugin-keychain-vault.ts
Show resolved
Hide resolved
packages/cactus-plugin-keychain-vault/src/main/typescript/plugin-keychain-vault.ts
Show resolved
Hide resolved
packages/cactus-plugin-keychain-vault/src/main/typescript/prometheus-exporter/metrics.ts
Show resolved
Hide resolved
...s/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts
Outdated
Show resolved
Hide resolved
...s/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts
Show resolved
Hide resolved
...s/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts
Show resolved
Hide resolved
...s/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts
Outdated
Show resolved
Hide resolved
jagpreetsinghsasan
force-pushed
the
feature-536
branch
from
9ec5ac8 to
aecb335
Compare
Primary Change -------------- 1. The keychain-vault plugin now includes the prometheus metrics exporter integration 2. OpenAPI spec now has api endpoint for the getting the prometheus metrics Refactorings that were also necessary to accomodate 1) and 2) ------------------------------------------------------------ 3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint 4. IPluginKeychainVaultOptions interface in PluginKeychainVault class now has a prometheusExporter optional field 5. The PluginKeychainMemory class has relevant functions and codes to incorporate prometheus exporter 6. Added Readme.md on the prometheus exporter usage Fixes hyperledger-cacti#536 Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan
force-pushed
the
feature-536
branch
from
aecb335 to
b9fe98b
Compare
petermetz
approved these changes
Mar 22, 2021
takeutak
approved these changes
Mar 23, 2021
takeutak
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(keychain-vault): add prometheus metrics
Resolve #536
Signed-off-by: Jagpreet Singh Sasan jagpreet.singh.sasan@accenture.com